Skip to content

Conversation

@linhtran174
Copy link
Contributor

No description provided.

@linhtran174 linhtran174 linked an issue Dec 1, 2023 that may be closed by this pull request
@freelerobot freelerobot changed the title boilerplate for express server localhost 1337 feat: boilerplate for express server localhost 1337 Dec 1, 2023
@linhtran174 linhtran174 requested a review from louis-jan December 1, 2023 16:04
Copy link
Contributor

@freelerobot freelerobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial code scaffold looks fine. I'm looking for how some of the shared extensions interface & logic (used across both server-only and nativeOS) will be refactored out given this PR. We should aim for as little code duplication as possible.

@linhtran174 linhtran174 requested a review from louis-jan December 4, 2023 15:05
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiro-v
Copy link
Contributor

hiro-v commented Dec 4, 2023

Next step I suggest @linhtran174 @louis-jan

  1. We can generate code in each API, or vice versa to prevent diff between code and docs
  2. We should serve UI locally for browsing API - should use swagger/ openai like we have in https://jan.ai/api-reference/. Then user can actually test API there

@linhtran174 linhtran174 merged commit 2627d95 into main Dec 5, 2023
@linhtran174 linhtran174 deleted the 768-fs-adapter-calling-server-api-for-handling-fs branch December 5, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

fs adapter calling server API for handling fs

5 participants